Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_route refactoring #1060

Merged
merged 1 commit into from
Nov 30, 2024
Merged

add_route refactoring #1060

merged 1 commit into from
Nov 30, 2024

Conversation

dave42w
Copy link
Contributor

@dave42w dave42w commented Nov 29, 2024

Description

This PR fixes #1059

Summary

This PR does the following

  1. use # type: ignore on the add_route of Router, MiddlewareRouter and WebSocketRouter to suppress mypy complaining about BaseRouter.add_route having different arguments and return values

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 3:59pm

Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #1060 will not alter performance

Comparing dave42w:add_route-refactor (e8b55a2) with main (7fe0c04)

Summary

✅ 146 untouched benchmarks

@dave42w
Copy link
Contributor Author

dave42w commented Nov 30, 2024

@sansyrox I'm seeing this same nox ci failure on just one python version/platform for several PRs.
It's something that these PRs haven't touched with we sockets. It seems strange that it's only an error on one of the platforms. Is it actually a weird bug?

@sansyrox
Copy link
Member

@dave42w , it is an issue with how the websockets are tested. I don't know for sure but we will probably have to fix it from there.

@sansyrox sansyrox merged commit 3d76169 into sparckles:main Nov 30, 2024
59 of 60 checks passed
@sansyrox
Copy link
Member

sansyrox commented Nov 30, 2024

Hey @dave42w 👋

Thank you for the great work. One request - could you please start using conventional commit syntax for Robyn(https://www.conventionalcommits.org/en/v1.0.0/) . It really helps me when I am going through the git log history

@dave42w
Copy link
Contributor Author

dave42w commented Nov 30, 2024

Hey @dave42w 👋

Thank you for the great work. One request - could you please start using conventional commit syntax for Robyn(https://www.conventionalcommits.org/en/v1.0.0/) . It really helps me when I am going through the git log history

I've not seen that before. I'll read it and try to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route simplication
2 participants