Skip to content

Commit

Permalink
update code with renaming some types
Browse files Browse the repository at this point in the history
  • Loading branch information
suhailmalik07 committed Oct 30, 2022
1 parent e3c6633 commit 50abf6e
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 18 deletions.
15 changes: 6 additions & 9 deletions src/routers/middleware_router.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use matchit::Node;

use anyhow::{bail, Error, Result};

use super::types::MiddlewareRouteType;
use crate::routers::types::MiddlewareRoute;

/// Contains the thread safe hashmaps of different routes
Expand All @@ -27,21 +27,18 @@ impl MiddlewareRouter {
}

#[inline]
fn get_relevant_map(
&self,
route: MiddlewareRouteType,
) -> Option<&RwLock<Node<(PyFunction, u8)>>> {
fn get_relevant_map(&self, route: MiddlewareRoute) -> Option<&RwLock<Node<(PyFunction, u8)>>> {
match route {
MiddlewareRouteType::BeforeRequest => Some(&self.before_request),
MiddlewareRouteType::AfterRequest => Some(&self.after_request),
MiddlewareRoute::BeforeRequest => Some(&self.before_request),
MiddlewareRoute::AfterRequest => Some(&self.after_request),
}
}

// Checks if the functions is an async function
// Inserts them in the router according to their nature(CoRoutine/SyncFunction)
pub fn add_route(
&self,
route_type: MiddlewareRouteType, // we can just have route type as WS
route_type: MiddlewareRoute,
route: &str,
handler: Py<PyAny>,
is_async: bool,
Expand All @@ -68,7 +65,7 @@ impl MiddlewareRouter {

pub fn get_route(
&self,
route_method: MiddlewareRouteType,
route_method: MiddlewareRoute,
route: &str, // check for the route method here
) -> Option<((PyFunction, u8), HashMap<String, String>)> {
// need to split this function in multiple smaller functions
Expand Down
10 changes: 5 additions & 5 deletions src/routers/types.rs
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
#[derive(Debug)]
pub enum MiddlewareRouteType {
pub enum MiddlewareRoute {
BeforeRequest,
AfterRequest,
}

impl MiddlewareRouteType {
pub fn from_str(input: &str) -> MiddlewareRouteType {
impl MiddlewareRoute {
pub fn from_str(input: &str) -> MiddlewareRoute {
match input {
"BEFORE_REQUEST" => MiddlewareRouteType::BeforeRequest,
"AFTER_REQUEST" => MiddlewareRouteType::AfterRequest,
"BEFORE_REQUEST" => MiddlewareRoute::BeforeRequest,
"AFTER_REQUEST" => MiddlewareRoute::AfterRequest,
_ => panic!("Invalid route type enum."),
}
}
Expand Down
8 changes: 4 additions & 4 deletions src/server.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use crate::request_handler::{handle_http_middleware_request, handle_http_request
use crate::routers::const_router::ConstRouter;

use crate::routers::router::Router;
use crate::routers::types::MiddlewareRouteType;
use crate::routers::types::MiddlewareRoute;
use crate::routers::{middleware_router::MiddlewareRouter, web_socket_router::WebSocketRouter};
use crate::shared_socket::SocketHeld;
use crate::types::{Headers, PyFunction};
Expand Down Expand Up @@ -303,7 +303,7 @@ impl Server {
) {
debug!("MiddleWare Route added for {} {} ", route_type, route);

let route_type = MiddlewareRouteType::from_str(route_type);
let route_type = MiddlewareRoute::from_str(route_type);

self.middleware_router
.add_route(route_type, route, handler, is_async, number_of_params)
Expand Down Expand Up @@ -399,7 +399,7 @@ async fn index(

// need a better name for this
let tuple_params =
match middleware_router.get_route(MiddlewareRouteType::BeforeRequest, req.uri().path()) {
match middleware_router.get_route(MiddlewareRoute::BeforeRequest, req.uri().path()) {
Some(((handler_function, number_of_params), route_params)) => {
let x = handle_http_middleware_request(
handler_function,
Expand Down Expand Up @@ -461,7 +461,7 @@ async fn index(
};

if let Some(((handler_function, number_of_params), route_params)) =
middleware_router.get_route(MiddlewareRouteType::AfterRequest, req.uri().path())
middleware_router.get_route(MiddlewareRoute::AfterRequest, req.uri().path())
{
let x = handle_http_middleware_request(
handler_function,
Expand Down

0 comments on commit 50abf6e

Please sign in to comment.