Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong json parameter in webhook documentation #885

Merged
merged 1 commit into from
Feb 19, 2021
Merged

fix wrong json parameter in webhook documentation #885

merged 1 commit into from
Feb 19, 2021

Conversation

MarcProe
Copy link
Contributor

fixes HTTP 400 Error: "{"errcode":"M_MISSING_PARAM","error":"Missing key 'avatar_url'"}"

fixes HTTP 400 Error: "{\"errcode\":\"M_MISSING_PARAM\",\"error\":\"Missing key 'avatar_url'\"}"
@spantaleev
Copy link
Owner

Are you sure?

The README for the project (https://github.com/turt2live/matrix-appservice-webhooks) says avatarUrl.

Searching for that also yields some results: https://github.com/turt2live/matrix-appservice-webhooks/search?q=avatarUrl

It also makes sense. Who would name this avatarUrl, while also using displayName - that's inconsistent.

@aaronraimist
Copy link
Contributor

Related: turt2live/matrix-appservice-webhooks#72

@spantaleev
Copy link
Owner

Thanks for finding that!

It sounds like that bridge is quite broken and even with avatar_url, it may not work well.

@MarcProe
Copy link
Contributor Author

I use the bridge with IFTTT to forward SMS. It works quite decently (if you use the "correct" parameter).
image

@spantaleev spantaleev merged commit 1c4d914 into spantaleev:master Feb 19, 2021
@spantaleev
Copy link
Owner

Alright! Let's merge this as it is, given that it works. Thank you! 👍

@MarcProe MarcProe deleted the fix-webhook-docs branch February 19, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants