Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update synapse 1.56.0 -> 1.57.0 #1766

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

aine-etke
Copy link
Collaborator

@aine-etke aine-etke commented Apr 19, 2022

no config changes

@spantaleev spantaleev merged commit dc508fc into spantaleev:master Apr 19, 2022
@aine-etke aine-etke deleted the update-synapse-1.57.0 branch April 19, 2022 12:32
@spantaleev
Copy link
Owner

Thanks! 👍


This changelog entry for Synapse v1.57 may be important to some users:

Changes to database schema for application services

Synapse v1.57.0 includes a matrix-org/synapse#12209 to the way transaction IDs are managed for application services. If your deployment uses a dedicated worker for application service traffic, it must be stopped when the database is upgraded (which normally happens when the main process is upgraded), to ensure the change is made safely without any risk of reusing transaction IDs.

Deployments which do not use separate worker processes can be upgraded as normal. Similarly, deployments where no applciation services are in use can be upgraded as normal.

@aine-etke
Copy link
Collaborator Author

But the start tag does the full stop

@spantaleev
Copy link
Owner

It does bring all services to a full stop, and then starts them again.

Various matrix-synapse-worker-*.service services depend on matrix-synapse.service (and sleep 5 seconds), so the main one should be starting before worker processes. Although.. those systemd dependencies and delays are not very reliable, so I suppose some worker could potentially start while matrix-synapse.service is still starting up or is slowly running some migrations.

From what I understand, it's safest if some application service worker only gets to start after matrix-synapse.service has managed to fully complete the migration.


Well, let's ignore it and see what happens. 🤞

@aine-etke
Copy link
Collaborator Author

Could you add a notice in the changelog about it?

spantaleev added a commit that referenced this pull request Apr 19, 2022
ksnieck pushed a commit to ksnieck/matrix-docker-ansible-deploy that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants