Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code-review: location regexp matching working? #2986

Closed
jolly-jump opened this issue Nov 8, 2023 · 1 comment
Closed

Code-review: location regexp matching working? #2986

jolly-jump opened this issue Nov 8, 2023 · 1 comment
Labels

Comments

@jolly-jump
Copy link
Contributor

Hi Stani,

based on #2954, where I am very sure (from the specs and the tests) that ^~ does not do any regexp matching, I came across two more lines where this is (probably) the intention:

location ^~ /_matrix/client/(r0|v1|v3|unstable)/(logout|logout/all) {

location ^~ /_matrix/client/(r0|v1|v3|unstable)/admin/(purge_media_cache|quarantine_media/.*) {

I could find that you introduced these lines 4 months ago for the matrix-media-repo. I cannot test this and I could not find who has this running to check if my suspicion (that these lines above do not match and thus do not work) is right.

@spantaleev
Copy link
Owner

Good catch!

Looks like various people are copy-pasting location blocks and do not really look into (or remember) what the ^~ prefix does. I've supposedly fixed it now.

cvwright pushed a commit to cvwright/matrix-docker-ansible-deploy that referenced this issue Jan 11, 2024
KarolosLykos pushed a commit to KarolosLykos/matrix-docker-ansible-deploy that referenced this issue Mar 5, 2024
@luixxiul luixxiul added the bug label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants