Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mjolnir 1.5.0 to 1.6.1 Update Issues info. #2296

Closed
FSG-Cat opened this issue Nov 24, 2022 · 0 comments · Fixed by #3128
Closed

Mjolnir 1.5.0 to 1.6.1 Update Issues info. #2296

FSG-Cat opened this issue Nov 24, 2022 · 0 comments · Fixed by #3128
Labels

Comments

@FSG-Cat
Copy link
Contributor

FSG-Cat commented Nov 24, 2022

Hello. This issue was opened just to document the issues i encountered while trying to make this update locally and properly.

The intention with this is to allow this to be referenced by anyone attempting to implement this in the playbook.

Attempting to add --mjolnir-config and the correct data path will just end up with the container saying it doesnt recognise this.

The following changes have been attempted and failed for me.
--mjolnir-config /data/config/production.yaml \
bot --mjolnir-config /data/config/production.yaml \

--bot
--mjolnir-config /data/config/production.yaml \

These changes have been attempted against the template file used for mjolnir at its latest revision as of time of writing together with the 1.6.1 image pulled via playbook not self built.

I am under the impression that its incorrect but not even attempting this whole ritual that is referenced in the update docs and just doing a straight version bump works but is probably considered bad practice and will probably break in the future. I did this my self but i would not recomend that we take this approach unless we are given an official all clear from a Mjolnir developer in the mjolnir room or on github for doing it like this.

FSG-Cat added a commit to FSG-Cat/matrix-docker-ansible-deploy that referenced this issue Jan 24, 2024
FSG-Cat added a commit to FSG-Cat/matrix-docker-ansible-deploy that referenced this issue Jan 24, 2024
FSG-Cat added a commit to FSG-Cat/matrix-docker-ansible-deploy that referenced this issue Jan 24, 2024
This should resolve [spantaleev#2296](spantaleev#2296) by fixing the noted issue.

This also paves the way for in the future working on D4A mode but that would require a rework to how these variables are done.
spantaleev added a commit that referenced this issue Jan 24, 2024
…g-Declare

Resolve #2296 by Explicitly telling Draupnir and Mjolnir where to find their configs.
KarolosLykos pushed a commit to KarolosLykos/matrix-docker-ansible-deploy that referenced this issue Mar 5, 2024
This should resolve [spantaleev#2296](spantaleev#2296) by fixing the noted issue.

This also paves the way for in the future working on D4A mode but that would require a rework to how these variables are done.
@luixxiul luixxiul added the bug label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants