This repository was archived by the owner on Mar 31, 2024. It is now read-only.
Spalger implement/scss url imports/mixin #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er/kibana into spalger-implement/scss-url-imports
…er/kibana into spalger-implement/scss-url-imports
- Moved svg assets to one folder under `ui/public/assets/images` - Deleted .less files
|
Oops, didn't mean to push this into my branch, lets keep it separate but I still think it's fine to close this PR |
|
👍 I'll just keep the branch live in my fork until your PR is in master |
spalger
pushed a commit
that referenced
this pull request
Apr 23, 2019
spalger
pushed a commit
that referenced
this pull request
May 8, 2019
* show grab and edit buttons when hovering over layer name * display layer details when layer name is clicked * add range to dynamic style property state * render dynamic ranges in TOC details * render symbol size and border width header in legend * simplify VectorStyle.getIcon * removed unused component * open TOC details on map load * save open TOC details state in embeddable config * show gradients for dynmaic fill color icon * round corners of dynamic icon if points only * add tooltip to legend label * add edit panel action to action panel * add functional test for details in legend * fix broken gis_page function doesLayerExist * add unit tests for VectorStyle.getDescriptorWithDynamicRanges * open actions menu on layer title click, add arrow up/down for togging layer details * Design cleanup of layers panel (#31) * fix functional test * update jest snapshots * refactor StylePropertyLegendRow to use same function to render lineWidth and iconSize legends * fix functional test * fix another functional test * make escapeLayerName function instead of instance method * move _isLayerDetailsOpen into prop from redux connector * remove index.js file * do not show legend details toggle when layer has not legend details * rename FillableVector to FillableRectangle * use mixin pattern instead of encapulated function call
spalger
pushed a commit
that referenced
this pull request
May 9, 2019
…6229) * show grab and edit buttons when hovering over layer name * display layer details when layer name is clicked * add range to dynamic style property state * render dynamic ranges in TOC details * render symbol size and border width header in legend * simplify VectorStyle.getIcon * removed unused component * open TOC details on map load * save open TOC details state in embeddable config * show gradients for dynmaic fill color icon * round corners of dynamic icon if points only * add tooltip to legend label * add edit panel action to action panel * add functional test for details in legend * fix broken gis_page function doesLayerExist * add unit tests for VectorStyle.getDescriptorWithDynamicRanges * open actions menu on layer title click, add arrow up/down for togging layer details * Design cleanup of layers panel (#31) * fix functional test * update jest snapshots * refactor StylePropertyLegendRow to use same function to render lineWidth and iconSize legends * fix functional test * fix another functional test * make escapeLayerName function instead of instance method * move _isLayerDetailsOpen into prop from redux connector * remove index.js file * do not show legend details toggle when layer has not legend details * rename FillableVector to FillableRectangle * use mixin pattern instead of encapulated function call
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@spalger
This PR shows the ideal situation of being able to consolidate all those full screen graphics to use one mixin and one assets folder.
It doesn't work with the current setup because of the use of the mixin. You get a 404 on
http://localhost:5601/hnq/built_assets/css/ui/images/bg_top_branded.svg 404 (Not Found).