Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openblas: fix prereqs / make race #35395

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

haampie
Copy link
Member

@haampie haampie commented Feb 8, 2023

Fix a race in the makefile where the shared lib was built before the
object files were available when doing make libs netlib shared

See OpenMathLib/OpenBLAS#3899

@spack spack deleted a comment from spackbot-app bot Feb 8, 2023
@haampie haampie force-pushed the openblas/fix-missing-prereqs branch from a566244 to 96be0df Compare February 8, 2023 15:33
@haampie
Copy link
Member Author

haampie commented Feb 9, 2023

@spackbot rerun pipeline

@spackbot-app
Copy link

spackbot-app bot commented Feb 9, 2023

I've started that pipeline for you!

@haampie
Copy link
Member Author

haampie commented Feb 16, 2023

@spackbot run pipeline

@spackbot-app
Copy link

spackbot-app bot commented Feb 16, 2023

I've started that pipeline for you!

Fix a race in the makefile where the shared lib was built before the
object files were available.

See OpenMathLib/OpenBLAS#3899
@haampie haampie force-pushed the openblas/fix-missing-prereqs branch from d11aabd to 4e7d3a0 Compare February 16, 2023 13:28
@alalazo alalazo enabled auto-merge (squash) February 16, 2023 15:44
@alalazo alalazo self-assigned this Feb 16, 2023
@haampie
Copy link
Member Author

haampie commented Feb 17, 2023

@spackbot run pipeline

@spackbot-app
Copy link

spackbot-app bot commented Feb 17, 2023

I've started that pipeline for you!

@haampie
Copy link
Member Author

haampie commented Feb 18, 2023

@spackbot run pipeline

@spackbot-app
Copy link

spackbot-app bot commented Feb 18, 2023

I've started that pipeline for you!

@alalazo alalazo merged commit 011c28a into spack:develop Feb 18, 2023
koysean pushed a commit to koysean/spack that referenced this pull request Feb 20, 2023
Fix a race in the makefile where the shared lib was built before the
object files were available.

See OpenMathLib/OpenBLAS#3899
@haampie haampie deleted the openblas/fix-missing-prereqs branch February 21, 2023 12:53
@haampie haampie mentioned this pull request Mar 6, 2023
4 tasks
jmcarcell pushed a commit to key4hep/spack that referenced this pull request Apr 13, 2023
Fix a race in the makefile where the shared lib was built before the
object files were available.

See OpenMathLib/OpenBLAS#3899
trz42 pushed a commit to trz42/software-layer that referenced this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants