Store failed and non-build jobs in the analytics database #942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our
process_job
function and all child data gathering functions to operate on failed jobs, as well as other job types likegenerate
, etc. This implementation has the following effects:JobDataDimension
LegacyJobAttempt
rows to the current format. This must be run manually, after this is deployed, as it's lengthy and not suitable to be run automatically in a Django migration.I've tested both the regular
process_job
workflow on various job types with real webhook payloads taken from Gitlab, as well as the job migration management command. Both seem to work well.This should remove the last vestiges of the Legacy models that are used as a part of the job processor. After this is merged, we can check that none of the legacy data is unaccounted for or otherwise still being relied upon, and make a follow on PR to finally remove them.