-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9/5] ENH: replace hidden imports with public ones #405
Conversation
Codecov Report
@@ Coverage Diff @@
## ajc-remove-private-imports-and-validate-notebooks #405 +/- ##
=====================================================================================
- Coverage 85.71% 85.58% -0.14%
=====================================================================================
Files 68 68
Lines 2668 2713 +45
=====================================================================================
+ Hits 2287 2322 +35
- Misses 381 391 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see the comments.
starfish/spots/_detector/detect.py
Outdated
from starfish.intensity_table import IntensityTable | ||
from starfish.munge import dataframe_to_multiindex | ||
from starfish.spots._spot_attributes import SpotAttributes | ||
from starfish.stack import ImageStack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sort
@@ -2,13 +2,13 @@ | |||
|
|||
import numpy as np | |||
import xarray as xr | |||
from starfish.intensity_table import IntensityTable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are first party.
9eca5d3
to
d631be4
Compare
0131e41
to
7ac70aa
Compare
7ac70aa
to
83c2804
Compare
72fca8b
to
52525d1
Compare
83c2804
to
1de340d
Compare
@@ -1,3 +1,4 @@ | |||
from ._spot_attributes import SpotAttributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sort it pls.
from starfish.spots._target_assignment import TargetAssignment | ||
from starfish.image._registration import Registration | ||
from starfish.image._segmentation import Segmentation | ||
from starfish.spots import Decoder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sort pls.
wait i already approved. lol. |
Tests are failing though. |
a2ee3e9
to
13d4636
Compare
1de340d
to
de0b612
Compare
This PR:
SpotAttributes
as a public object instarfish.spots