Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TransformsList class with to_dict() and from_dict() methods #1956

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

njmei
Copy link
Collaborator

@njmei njmei commented Sep 7, 2021

This PR adds the ability to load/save a starfish TransformsList as a Python dict.

Luckily, tests already covered loading and saving from *.json and because those existing method now call these new dict load/save methods, they happen to be covered too.

@njmei njmei force-pushed the update-transforms-list branch from 771820b to eef123e Compare October 17, 2021 18:13
This commit adds the ability to output the TransformsList
as a Python dictionary as well as the ability to
instantiate a TransformsList from a Python dictionary.
@njmei njmei force-pushed the update-transforms-list branch from eef123e to f485e6f Compare October 17, 2021 18:32
Copy link
Collaborator

@berl berl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@berl berl merged commit 8741af1 into spacetx:master Oct 18, 2021
@njmei njmei deleted the update-transforms-list branch October 18, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants