-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix localmaxpeakfinder spot_props filter #1839
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1839 +/- ##
===========================================
- Coverage 87.77% 55.91% -31.87%
===========================================
Files 168 168
Lines 5785 5789 +4
===========================================
- Hits 5078 3237 -1841
- Misses 707 2552 +1845
Continue to review full report at Codecov.
|
fixes #1836 |
ttung
approved these changes
Jul 15, 2020
please remove the "expression" file before you commit, however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed filtering of
spot_props
whose areas are too large or too small inimage_to_spots
oflocal_max_peak_finder
. It can now handle 2D xarrays (i.e.is_volume=False
) and can correctly set pixels toFalse
(removing aspot_prop
) for 3D xarrays.In addition, added details for how to set
local_max_peak_finder
parameters in its tutorial.