Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Easy] - Changing return value of PixelDecoding to DecodedIntensityTable #1823

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

shanaxel42
Copy link
Collaborator

No description provided.

@shanaxel42 shanaxel42 requested review from ttung and mattcai February 28, 2020 18:06
@codecov-io
Copy link

codecov-io commented Feb 28, 2020

Codecov Report

Merging #1823 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1823      +/-   ##
==========================================
- Coverage   90.13%   90.08%   -0.06%     
==========================================
  Files         254      254              
  Lines        9461     9463       +2     
==========================================
- Hits         8528     8525       -3     
- Misses        933      938       +5
Impacted Files Coverage Δ
starfish/core/spots/DetectPixels/_base.py 68.42% <100%> (ø) ⬆️
...fish/core/spots/DetectPixels/pixel_spot_decoder.py 100% <100%> (ø) ⬆️
...re/spots/DetectPixels/combine_adjacent_features.py 98.19% <100%> (+0.01%) ⬆️
starfish/core/_version.py 45.32% <0%> (-1.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed770c5...7f73baf. Read the comment docs.

Copy link
Collaborator

@ttung ttung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, could you elaborate in your commit message what the motivation behind this change was?

@mattcai mattcai merged commit 3a2c0b5 into master Feb 28, 2020
@mattcai
Copy link
Contributor

mattcai commented Feb 28, 2020

PixelDecoding should return a DecodedIntensityTable to match SpotDecoding and support methods like to_expression_matrix() but it was incorrectly returning an IntensityTable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants