Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate is_volume parameter with trackpy #1820

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Feb 25, 2020

  1. is_volume is deprecated and documentation removed.
  2. if someone passes in is_volume=False, we raise an error.
  3. if someone passes in is_volume=True, we raise a warning.

Fixes #1818

@ttung ttung requested a review from shanaxel42 February 25, 2020 23:28
@codecov-io
Copy link

codecov-io commented Feb 25, 2020

Codecov Report

Merging #1820 into master will decrease coverage by 0.06%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1820      +/-   ##
==========================================
- Coverage   90.13%   90.07%   -0.07%     
==========================================
  Files         254      254              
  Lines        9461     9463       +2     
==========================================
- Hits         8528     8524       -4     
- Misses        933      939       +6
Impacted Files Coverage Δ
...e/spots/FindSpots/trackpy_local_max_peak_finder.py 97.91% <75%> (-2.09%) ⬇️
starfish/core/_version.py 45.32% <0%> (-1.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed770c5...f0b520e. Read the comment docs.

1. is_volume is deprecated and documentation removed.
2. if someone passes in is_volume=False, we raise an error.
3. if someone passes in is_volume=True, we raise a warning.

Fixes #1818
@ttung ttung force-pushed the tonytung-trackpy-must-be-3d branch from 87b2857 to f0b520e Compare February 26, 2020 21:43
@ttung ttung merged commit 48955d9 into master Feb 28, 2020
@ttung ttung deleted the tonytung-trackpy-must-be-3d branch February 28, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't support is_volume=False with TrackPy
3 participants