Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easy] add h5py to pinned requirements #1763

Merged
merged 1 commit into from
Jan 31, 2020
Merged

[easy] add h5py to pinned requirements #1763

merged 1 commit into from
Jan 31, 2020

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Jan 31, 2020

#1740 added h5py but not to the pinned requirements files. That resulted in unhappy travis runs (e.g., https://travis-ci.com/spacetx/starfish/builds/146897038)

Test plan: none

#1740 added h5py but not to the pinned requirements files.  That resulted in unhappy travis runs (e.g., https://travis-ci.com/spacetx/starfish/builds/146897038)

Test plan: none
@ttung ttung requested a review from shanaxel42 January 31, 2020 18:33
@codecov-io
Copy link

codecov-io commented Jan 31, 2020

Codecov Report

Merging #1763 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1763   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files         252      252           
  Lines        9307     9307           
=======================================
  Hits         8366     8366           
  Misses        941      941

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b4264...a48bd01. Read the comment docs.

@ttung ttung merged commit 8639799 into master Jan 31, 2020
@ttung ttung deleted the tonytung-h5py branch January 31, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants