Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add level_method to the clip filters. #1758

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Jan 27, 2020

Test plan: make -j fast
Fixes: #1757

@ttung ttung requested a review from shanaxel42 January 27, 2020 23:13
@ttung ttung force-pushed the tonytung-add-levels-to-clip branch from 66462a2 to 1352392 Compare January 27, 2020 23:14
Test plan: `make -j fast`
Fixes: #1757
@ttung ttung force-pushed the tonytung-add-levels-to-clip branch from 1352392 to 300a243 Compare January 27, 2020 23:27
@codecov-io
Copy link

codecov-io commented Jan 27, 2020

Codecov Report

Merging #1758 into master will decrease coverage by 0.01%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1758      +/-   ##
==========================================
- Coverage   90.09%   90.08%   -0.02%     
==========================================
  Files         251      251              
  Lines        9260     9270      +10     
==========================================
+ Hits         8343     8351       +8     
- Misses        917      919       +2
Impacted Files Coverage Δ
...rfish/core/image/Filter/clip_percentile_to_zero.py 100% <100%> (ø) ⬆️
starfish/core/image/Filter/clip_value_to_zero.py 60.86% <66.66%> (-2.77%) ⬇️
starfish/core/image/Filter/clip.py 93.93% <81.81%> (-6.07%) ⬇️
starfish/core/imagestack/imagestack.py 93.11% <0%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3c53a5...300a243. Read the comment docs.

@ttung ttung merged commit c0b4264 into master Jan 31, 2020
@ttung ttung deleted the tonytung-add-levels-to-clip branch January 31, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add levels parameter to all relevant clip filters (incl ClipPercentileToZero)
3 participants