Modularize starfish.core.experiment.builder #1738
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to import modules in starfish.core.experiment.builder without slurping in the whole thing. As it stands, if I add a dependency from starfish.core.imagestack to any module in starfish.core.experiment.builder, it creates a circular dependency. This moves the contents of starfish.core.experiment.builder.init.py to a standalone module.
The external api (starfish.experiment.builder) is maintained.
Test plan:
make -j lint mypy fast-test