Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize starfish.core.experiment.builder #1738

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Jan 16, 2020

We need to be able to import modules in starfish.core.experiment.builder without slurping in the whole thing. As it stands, if I add a dependency from starfish.core.imagestack to any module in starfish.core.experiment.builder, it creates a circular dependency. This moves the contents of starfish.core.experiment.builder.init.py to a standalone module.

The external api (starfish.experiment.builder) is maintained.

Test plan: make -j lint mypy fast-test

We need to be able to import modules in starfish.core.experiment.builder without slurping in the whole thing.  As it stands, if I add a dependency from starfish.core.imagestack to any module in  starfish.core.experiment.builder, it creates a circular dependency.  This moves the contents of starfish.core.experiment.builder.__init__.py to a standalone module.

The external api (starfish.experiment.builder) is maintained.

Test plan: `make -j lint mypy fast-test`
@codecov-io
Copy link

codecov-io commented Jan 16, 2020

Codecov Report

Merging #1738 into master will increase coverage by <.01%.
The diff coverage is 95.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1738      +/-   ##
==========================================
+ Coverage   90.36%   90.36%   +<.01%     
==========================================
  Files         248      248              
  Lines        9167     9178      +11     
==========================================
+ Hits         8284     8294      +10     
- Misses        883      884       +1
Impacted Files Coverage Δ
starfish/experiment/builder.py 0% <0%> (ø) ⬆️
...rfish/core/experiment/builder/test/test_inplace.py 98.61% <100%> (+0.01%) ⬆️
...sh/core/experiment/builder/structured_formatter.py 88.02% <100%> (ø) ⬆️
...ilder/test/structured_formatter/test_single_fov.py 100% <100%> (ø) ⬆️
...fish/core/imagestack/test/factories/all_purpose.py 100% <100%> (ø) ⬆️
...builder/test/structured_formatter/test_tilepath.py 100% <100%> (ø) ⬆️
starfish/core/imagestack/test/test_coordinates.py 96.47% <100%> (+0.04%) ⬆️
.../core/imagestack/test/factories/synthetic_stack.py 100% <100%> (ø) ⬆️
...ish/core/imagestack/test/test_slicedimage_dtype.py 95.06% <100%> (ø) ⬆️
...der/test/structured_formatter/test_multiple_fov.py 100% <100%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee53dcc...8533b7d. Read the comment docs.

@ttung ttung merged commit 99a7f43 into master Jan 22, 2020
@ttung ttung deleted the tonytung-modularize branch January 22, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants