Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove starfish.types.Clip #1729

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Remove starfish.types.Clip #1729

merged 1 commit into from
Jan 15, 2020

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Jan 10, 2020

It has been deprecated in favor of Clip.

Test plan: make -j fast

Depends on #1724
Fixes #1723

@ttung ttung requested a review from shanaxel42 January 10, 2020 18:43
@codecov-io
Copy link

codecov-io commented Jan 10, 2020

Codecov Report

Merging #1729 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1729      +/-   ##
==========================================
+ Coverage    90.2%   90.33%   +0.12%     
==========================================
  Files         248      248              
  Lines        9159     9137      -22     
==========================================
- Hits         8262     8254       -8     
+ Misses        897      883      -14
Impacted Files Coverage Δ
starfish/types.py 100% <ø> (ø) ⬆️
starfish/core/types/__init__.py 100% <ø> (ø) ⬆️
starfish/core/imagestack/imagestack.py 92.95% <ø> (+3.3%) ⬆️
starfish/core/image/Filter/gaussian_high_pass.py 100% <100%> (ø) ⬆️
starfish/core/image/Filter/element_wise_mult.py 80% <100%> (ø) ⬆️
starfish/core/image/Filter/mean_high_pass.py 100% <100%> (ø) ⬆️
starfish/core/image/Filter/reduce.py 95% <100%> (ø) ⬆️
...core/image/Filter/richardson_lucy_deconvolution.py 95.45% <100%> (ø) ⬆️
starfish/core/image/Filter/gaussian_low_pass.py 100% <100%> (ø) ⬆️
starfish/core/image/Filter/map.py 92.3% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ffbbbf...8195c86. Read the comment docs.

@ttung ttung force-pushed the tonytung-remove-clip-uses branch from 09f0856 to dc92d1f Compare January 13, 2020 22:06
@ttung ttung force-pushed the tonytung-remove-clip-uses branch from dc92d1f to 6a523f5 Compare January 13, 2020 22:08
@ttung ttung force-pushed the tonytung-clip branch 3 times, most recently from dc45d1b to b1cf9ec Compare January 14, 2020 06:38
@ttung ttung force-pushed the tonytung-remove-clip-uses branch from 32eec5e to eb8497a Compare January 15, 2020 00:03
@ttung ttung force-pushed the tonytung-clip branch 2 times, most recently from e8a87b7 to e621636 Compare January 15, 2020 02:09
@ttung ttung changed the base branch from tonytung-remove-clip-uses to master January 15, 2020 03:31
It has been deprecated in favor of Clip.

Test plan: make -j fast

Fixes #1723
@ttung ttung merged commit b8723b5 into master Jan 15, 2020
@ttung ttung deleted the tonytung-clip branch January 15, 2020 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove deprecated "Clip" code in favor of Levels
3 participants