Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3D support to target assignment. #1699

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Add 3D support to target assignment. #1699

merged 1 commit into from
Dec 17, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Dec 13, 2019 •
edited
Loading

If 3D data is present, use it to limit target assignment. If zplane information is not available, just set the bounds to -inf,+inf.

Part of #53. This fixes @dganguli's comment dated from Feb 9, 2018!

@ttung ttung requested a review from shanaxel42 December 13, 2019 22:07
@ttung ttung mentioned this pull request Dec 14, 2019
Merged
@ttung ttung force-pushed the tonytung-fix-assignment branch from 51ae71b to e766605 Compare December 14, 2019 06:08
@ttung ttung force-pushed the tonytung-fix-assignment branch from e766605 to e38f465 Compare December 14, 2019 06:09
@codecov-io
Copy link

codecov-io commented Dec 14, 2019 •
edited
Loading

Codecov Report

Merging #1699 into master will decrease coverage by 0.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1699      +/-   ##
==========================================
- Coverage   90.05%   90.04%   -0.02%     
==========================================
  Files         245      245              
  Lines        9140     9149       +9     
==========================================
+ Hits         8231     8238       +7     
- Misses        909      911       +2
Impacted Files Coverage Δ
starfish/core/spots/AssignTargets/label.py 91.17% <81.81%> (-4.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cadab6b...2f3f094. Read the comment docs.

@ttung ttung force-pushed the tonytung-fix-assignment branch from e38f465 to bae8f92 Compare December 16, 2019 17:45
@ttung ttung force-pushed the tonytung-fix-assignment branch from bae8f92 to 1d0bf3d Compare December 16, 2019 18:58
Add 3D support to target assignment.
2f3f094 
If 3D data is present, use it to limit target assignment.  If zplane information is not available, just set the bounds to -inf,+inf.

Part of #53.  This fixes @dganguli's comment dated from Feb 9, 2018!
@ttung ttung force-pushed the tonytung-fix-assignment branch from 1d0bf3d to 2f3f094 Compare December 16, 2019 21:37
ttung pushed a commit that referenced this pull request Dec 16, 2019
Use the new watershed component to finish componentizing the existing…
d46d7a9 
… watershed

Use the component from #1700 to replace the remaining procedural code in the existing watershed component.

Depends on #1700, #1699, #1694
Test plan: visually the ISS notebook looks the same.
@ttung ttung merged commit e08c260 into master Dec 17, 2019
@ttung ttung deleted the tonytung-fix-assignment branch December 17, 2019 20:42
ttung pushed a commit that referenced this pull request Jan 15, 2020
Use the new watershed component to finish componentizing the existing…
17785db 
… watershed (#1701)

Use the component from #1700 to replace the remaining procedural code in the existing watershed component.

Depends on #1700, #1699, #1694
Test plan: visually the ISS notebook looks the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanaxel42 shanaxel42 shanaxel42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttung @codecov-io @shanaxel42