Provide an apply method to binary mask collections. #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1655 +/- ##
=========================================
+ Coverage 90.06% 90.1% +0.04%
=========================================
Files 223 223
Lines 8563 8599 +36
=========================================
+ Hits 7712 7748 +36
Misses 851 851
Continue to review full report at Codecov.
|
ttung
force-pushed
the
tonytung-binary-mask-apply
branch
from
5b81f31 to
67e156f
Compare
ttung
force-pushed
the
tonytung-binary-mask-col-factories
branch
from
fde868a to
a3a126b
Compare
ttung
force-pushed
the
tonytung-binary-mask-apply
branch
from
67e156f to
87cef15
Compare
ttung
force-pushed
the
tonytung-binary-mask-col-factories
branch
from
a3a126b to
bb8c6a4
Compare
ttung
force-pushed
the
tonytung-binary-mask-apply
branch
from
87cef15 to
0a6650a
Compare
ttung
force-pushed
the
tonytung-binary-mask-col-factories
branch
from
bb8c6a4 to
26a12d9
Compare
ttung
force-pushed
the
tonytung-binary-mask-apply
branch
from
0a6650a to
05557b9
Compare
ttung
force-pushed
the
tonytung-binary-mask-col-factories
branch
from
26a12d9 to
d69ddf3
Compare
ttung
force-pushed
the
tonytung-binary-mask-apply
branch
from
05557b9 to
ba23d8e
Compare
ttung
force-pushed
the
tonytung-binary-mask-col-factories
branch
from
d69ddf3 to
f12e14d
Compare
ttung
force-pushed
the
tonytung-binary-mask-apply
branch
from
ba23d8e to
57e22c7
Compare
ttung
force-pushed
the
tonytung-binary-mask-col-factories
branch
from
f12e14d to
ddc6148
Compare
ttung
force-pushed
the
tonytung-binary-mask-apply
branch
from
57e22c7 to
00a0c58
Compare
ttung
force-pushed
the
tonytung-binary-mask-col-factories
branch
from
ddc6148 to
abc468d
Compare
ttung
force-pushed
the
tonytung-binary-mask-apply
branch
from
00a0c58 to
0017809
Compare
ttung
force-pushed
the
tonytung-binary-mask-col-factories
branch
from
abc468d to
ff2c472
Compare
ttung
force-pushed
the
tonytung-binary-mask-apply
branch
from
0017809 to
d5f4f42
Compare
ttung
force-pushed
the
tonytung-binary-mask-col-factories
branch
from
ff2c472 to
e9e12d2
Compare
ttung
force-pushed
the
tonytung-binary-mask-apply
branch
3 times, most recently
from
5e90a78 to
efe3314
Compare
ttung
changed the base branch from
tonytung-binary-mask-col-factories
to
master
ttung
force-pushed
the
tonytung-binary-mask-apply
branch
from
efe3314 to
098435d
Compare
ttung
force-pushed
the
tonytung-binary-mask-apply
branch
from
098435d to
04627c7
Compare
ttung
force-pushed
the
tonytung-binary-mask-apply
branch
from
04627c7 to
963fc4d
Compare
This allows a method to be applied to the individual masks and constituted into a new binary mask collection. Depends on #1653 Test plan: Wrote a test that performed binary dilation on the standard set of masks used for testing, and verified the results were somewhat sane.
ttung
force-pushed
the
tonytung-binary-mask-apply
branch
from
963fc4d to
5bd39db
Compare
shanaxel42
approved these changes
Nov 21, 2019
ttung
pushed a commit
that referenced
this pull request
Nov 22, 2019
This PR introduces filters to take a binary mask collection to produce another binary mask collection. A map filter is added that can take arbitrary methods in numpy/scipy/skimage and run them against the binary masks. Depends on #1655 Test plan: Added a simple test that does binary dilation on binary masks.
ttung
pushed a commit
that referenced
this pull request
Nov 22, 2019
This PR introduces filters to take a binary mask collection to produce another binary mask collection. A map filter is added that can take arbitrary methods in numpy/scipy/skimage and run them against the binary masks. Depends on #1655 Test plan: Added a simple test that does binary dilation on binary masks.
ttung
pushed a commit
that referenced
this pull request
Dec 13, 2019
This is the counterpart to the apply provided in #1655. Test plan: Added a test that reduced using xors. Because we have boring test data that don't overlap, this is one way of generating interesting output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a method to be applied to the individual masks and constituted into a new binary mask collection.
Depends on #1653
Test plan: Wrote a test that performed binary dilation on the standard set of masks used for testing, and verified the results were somewhat sane.