Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3dsmFish build error #1648

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Fix 3dsmFish build error #1648

merged 1 commit into from
Nov 13, 2019

Conversation

shanaxel42
Copy link
Collaborator

No description provided.

@shanaxel42 shanaxel42 changed the title fixing travis Fix 3dsmFish build error Nov 13, 2019
@shanaxel42 shanaxel42 requested a review from ttung November 13, 2019 17:00
@codecov-io
Copy link

codecov-io commented Nov 13, 2019

Codecov Report

Merging #1648 into master will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1648      +/-   ##
==========================================
+ Coverage   89.67%   90.03%   +0.36%     
==========================================
  Files         221      221              
  Lines        8230     8734     +504     
==========================================
+ Hits         7380     7864     +484     
- Misses        850      870      +20
Impacted Files Coverage Δ
starfish/core/test/test_display.py 44.44% <0%> (-0.72%) ⬇️
starfish/core/types/_spot_finding_results.py 97.1% <0%> (-0.52%) ⬇️
starfish/core/image/Segment/watershed.py 96.23% <0%> (-0.32%) ⬇️
starfish/core/binary_mask/test/test_binary_mask.py 100% <0%> (ø) ⬆️
starfish/core/binary_mask/test/test_expand.py 100% <0%> (ø) ⬆️
starfish/types.py 100% <0%> (ø) ⬆️
starfish/core/spots/DecodeSpots/trace_builders.py 100% <0%> (ø) ⬆️
...tarfish/core/spots/FindSpots/spot_finding_utils.py 100% <0%> (ø) ⬆️
starfish/core/types/_constants.py 98.63% <0%> (+0.38%) ⬆️
...ish/core/imagestack/test/test_slicedimage_dtype.py 95.74% <0%> (+0.68%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7892e0a...cd97ea2. Read the comment docs.

@shanaxel42 shanaxel42 merged commit 9653f7a into master Nov 13, 2019
@shanaxel42 shanaxel42 deleted the saxlerod-fix-3dsmsih branch November 13, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants