Methods for uncropping binary masks. #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## tonytung-coordinate-cleanup #1647 +/- ##
==============================================================
Coverage ? 89.75%
==============================================================
Files ? 220
Lines ? 8290
Branches ? 0
==============================================================
Hits ? 7441
Misses ? 849
Partials ? 0
Continue to review full report at Codecov.
|
ttung
force-pushed
the
tonytung-uncrop
branch
from
0ab6a76 to
6f104cb
Compare
shanaxel42
approved these changes
Nov 12, 2019
ttung
force-pushed
the
tonytung-uncrop
branch
3 times, most recently
from
eb49e05 to
c44608b
Compare
ttung
force-pushed
the
tonytung-coordinate-cleanup
branch
from
c0a165b to
f61fe5f
Compare
ttung
force-pushed
the
tonytung-uncrop
branch
from
c44608b to
6e3f361
Compare
ttung
force-pushed
the
tonytung-coordinate-cleanup
branch
from
f61fe5f to
91b5518
Compare
ttung
force-pushed
the
tonytung-uncrop
branch
6 times, most recently
from
84c0133 to
d950271
Compare
ttung
force-pushed
the
tonytung-coordinate-cleanup
branch
from
3aee79b to
abcb24f
Compare
ttung
force-pushed
the
tonytung-uncrop
branch
5 times, most recently
from
fd63cdb to
922f2be
Compare
ttung
force-pushed
the
tonytung-coordinate-cleanup
branch
from
5453a59 to
915a4a6
Compare
ttung
force-pushed
the
tonytung-uncrop
branch
2 times, most recently
from
5806efa to
7339bfd
Compare
ttung
force-pushed
the
tonytung-uncrop
branch
3 times, most recently
from
09e4e42 to
f16ede2
Compare
The existing builders for binary masks crop the masks to the smallest box that fits the non-zero data. This adds a method to reverse the crop when retrieving the masks. Documentation is also added to the builders' docblocks to indicate that they crop the masks. Note that the constructor of BinaryMaskCollection does _not_ crop the masks. The builders decide what they want to do. Depends on #1632 Test plan: Add tests to verify the uncropping works as expected.
ttung
force-pushed
the
tonytung-uncrop
branch
from
f16ede2 to
11046e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing builders for binary masks crop the masks to the smallest box that fits the non-zero data. This adds a method to reverse the crop when retrieving the masks. Documentation is also added to the builders' docblocks to indicate that they crop the masks.
Note that the constructor of BinaryMaskCollection does not crop the masks. The builders decide what they want to do.
Depends on #1632
Test plan: Add tests to verify the uncropping works as expected.