Support multiple codewords for the same target #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1646 +/- ##
=========================================
Coverage ? 89.87%
=========================================
Files ? 220
Lines ? 8145
Branches ? 0
=========================================
Hits ? 7320
Misses ? 825
Partials ? 0
Continue to review full report at Codecov.
|
ttung
force-pushed
the
tonytung-codebook-to-json-test
branch
from
f5218ec to
eaf77da
Compare
ttung
force-pushed
the
tonytung-multiple-words-for-target
branch
from
00d4993 to
5c0839e
Compare
`to_json` walks through each of the targets/r/c in a codebook when trying to save. Unfortunately, selecting an array with the same target twice results in a 3D array (target/r/c) rather than a 2D array (r/c). This PR rewrites to_json so it can handle multiple codewords that decode to the same target. Rather than selecting by label, we walk through each of the targets by integer offset. This also optimizes the walkthrough of the codebook object by finding all the non-zero points in numpy code rather than in python code. With the seqFISH dataset, this is at least a 10x speedup in writing out the json file. With denser codebooks, the speedup probably is inconsequential. Test plan: wrote a test that has multiple codewords for the same target. it crashes without the fix and succeehds with the fix. Fixes: #1643
ttung
force-pushed
the
tonytung-multiple-words-for-target
branch
from
5c0839e to
ffbf5d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_jsonwalks through each of the targets/r/c in a codebook when trying to save. Unfortunately, selecting an array with the same target twice results in a 3D array (target/r/c) rather than a 2D array (r/c).This PR rewrites to_json so it can handle multiple codewords that decode to the same target. Rather than selecting by label, we walk through each of the targets by integer offset. This also optimizes the walkthrough of the codebook object by finding all the non-zero points in numpy code rather than in python code. With the seqFISH dataset, this is at least a 10x speedup in writing out the json file. With denser codebooks, the speedup probably is inconsequential.
Test plan: wrote a test that has multiple codewords for the same target. it crashes without the fix and succeehds with the fix.
Fixes: #1643