Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging improvements #1617

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Logging improvements #1617

merged 1 commit into from
Oct 18, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Oct 17, 2019

  1. Reduce the susceptibility for circular imports. Right now, there is an arc from logging -> types -> SpotFindingResults -> logging.
  2. Add a method to decode an encoded log back into a Log object.
  3. Expose Log as a top-level starfish construct. (i.e., in the starfish namespace)

Test plan: travvvvvvis.

Logging improvements
b9a25fe 
1. Reduce the susceptibility for circular imports.  Right now, there is an arc from logging -> types -> SpotFindingResults -> logging.
2. Add a method to decode an encoded log back into a Log object.
3. Expose Log as a top-level starfish construct. (i.e., in the `starfish` namespace)

Test plan: travvvvvvis.
@ttung ttung requested a review from shanaxel42 October 17, 2019 21:11
@codecov-io
Copy link

codecov-io commented Oct 17, 2019 •
edited
Loading

Codecov Report

Merging #1617 into master will decrease coverage by 0.06%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1617      +/-   ##
==========================================
- Coverage   88.04%   87.98%   -0.07%     
==========================================
  Files         155      155              
  Lines        5455     5461       +6     
==========================================
+ Hits         4803     4805       +2     
- Misses        652      656       +4
Impacted Files Coverage Δ
starfish/__init__.py 100% <100%> (ø) ⬆️
starfish/core/util/logging.py 89.13% <66.66%> (-8.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2df275...b9a25fe. Read the comment docs.

@ttung ttung mentioned this pull request Oct 17, 2019
Merged
@ttung ttung merged commit 6c02128 into master Oct 18, 2019
ttung pushed a commit that referenced this pull request Oct 18, 2019
Add a label image data type
a629a74 
Rather than passing around a naked 2D/3D array as a label image, create a type for holding that data.

Test plan: see tests!
Depends on #1617
Part of #1497
ttung pushed a commit that referenced this pull request Oct 24, 2019
Add a label image data type
45aedc4 
Rather than passing around a naked 2D/3D array as a label image, create a type for holding that data.

Test plan: see tests!
Depends on #1617
Part of #1497
ttung pushed a commit that referenced this pull request Oct 28, 2019
Add a label image data type (#1619)
98d54af 
Rather than passing around a naked 2D/3D array as a label image, create a type for holding that data.

Test plan: see tests!
Depends on #1617
Part of #1497
@ttung ttung deleted the tonytung-logging-improvements branch October 28, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanaxel42 shanaxel42 shanaxel42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttung @codecov-io @shanaxel42