Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __slots__ to classes that subclass xr.DataArray #1607

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Oct 9, 2019

The absence of __slots__ triggers a warning.

Test plan: travis alltest!

@ttung ttung requested a review from shanaxel42 October 9, 2019 21:33
Copy link
Collaborator

@shanaxel42 shanaxel42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for doing this!

@ttung ttung force-pushed the tonytung-slots-alltest branch 2 times, most recently from e300918 to 9766498 Compare October 10, 2019 00:03
@codecov-io
Copy link

codecov-io commented Oct 10, 2019

Codecov Report

Merging #1607 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1607      +/-   ##
==========================================
+ Coverage   88.04%   88.05%   +<.01%     
==========================================
  Files         151      151              
  Lines        5171     5175       +4     
==========================================
+ Hits         4553     4557       +4     
  Misses        618      618
Impacted Files Coverage Δ
...sh/core/intensity_table/decoded_intensity_table.py 100% <100%> (ø) ⬆️
starfish/core/codebook/codebook.py 96.77% <100%> (+0.02%) ⬆️
starfish/core/intensity_table/intensity_table.py 96.29% <100%> (+0.03%) ⬆️
...arfish/core/expression_matrix/expression_matrix.py 52% <100%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58eb7ac...d804cd5. Read the comment docs.

@ttung ttung force-pushed the tonytung-slots-alltest branch 2 times, most recently from cf074de to b270b63 Compare October 10, 2019 06:19
The absence of __slots__ triggers a warning.

Test plan: travis alltest!
@ttung ttung force-pushed the tonytung-slots-alltest branch from b270b63 to d804cd5 Compare October 10, 2019 08:16
@ttung
Copy link
Collaborator Author

ttung commented Oct 10, 2019

@shanaxel42 said ok on slack. landdddiiiiiiing.

@ttung ttung merged commit 1f93768 into master Oct 10, 2019
@ttung ttung deleted the tonytung-slots-alltest branch October 10, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants