Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dimension ordering on Codebook and IntensityTable #1600

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Fix dimension ordering on Codebook and IntensityTable #1600

merged 1 commit into from
Oct 4, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Oct 2, 2019

These two seem to think that 'c' precedes 'r', which is different from the rest of the codebase.

Fix dimension ordering on Codebook and IntensityTable
005b513 
These two seem to think that 'c' precedes 'r', which is different from the rest of the codebase.
@ttung ttung mentioned this pull request Oct 4, 2019
Merged
ambrosejcarr
ambrosejcarr approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@ambrosejcarr ambrosejcarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@ttung ttung merged commit 35e8880 into master Oct 4, 2019
@ttung ttung mentioned this pull request Oct 5, 2019
Merged
@ttung ttung deleted the tonytung-fix-dims-alltest branch October 9, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrosejcarr ambrosejcarr ambrosejcarr approved these changes

@shanaxel42 shanaxel42 Awaiting requested review from shanaxel42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttung @ambrosejcarr