Test case for multiprocessing + imagestack #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1589 +/- ##
=======================================
Coverage 88.04% 88.04%
=======================================
Files 151 151
Lines 5171 5171
=======================================
Hits 4553 4553
Misses 618 618Continue to review full report at Codecov.
|
ttung
force-pushed
the
tonytung-multiprocessing
branch
2 times, most recently
from
e9012c2 to
d66dfb1
Compare
ttung
force-pushed
the
tonytung-multiprocessing
branch
4 times, most recently
from
1a63fb1 to
df81012
Compare
shanaxel42
approved these changes
Oct 4, 2019
ttung
force-pushed
the
tonytung-multiprocessing
branch
7 times, most recently
from
2fbbf98 to
9b90b32
Compare
We want to support multiprocessing + imagestack for two use cases: 1. algorithms that do not release the GIL do not run well under multithreading. 2. it allows us to parallelize across FOVs in an interesting way [1] This adds a test case that we can pass an ImageStack to a child process for processing. Note that this will not pass travis until spacetx/slicedimage#125 is landed and released. Test plan: this is the test plan Depends on #1586 [1] Ideally, we should make it such that the child workers cooperatively share the compute resources. This is not done today. See #1588 for what needs to be done next.
ttung
force-pushed
the
tonytung-multiprocessing
branch
from
9b90b32 to
1753094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to support multiprocessing + imagestack for two use cases:
This adds a test case that we can pass an ImageStack to a child process for processing.
Note that this will not pass travis until spacetx/slicedimage#125 is landed and released.
Test plan: this is the test plan
Depends on #1586
[1] Ideally, we should make it such that the child workers cooperatively share the compute resources. This is not done today. See #1588 for what needs to be done next.