Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easy] - fixing all expression matrix saves #1413

Merged
merged 9 commits into from
Jun 19, 2019
Merged

Conversation

shanaxel42
Copy link
Collaborator

Should fix #1411, also added small test

@codecov-io
Copy link

codecov-io commented Jun 18, 2019

Codecov Report

Merging #1413 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1413      +/-   ##
==========================================
+ Coverage   89.42%   89.44%   +0.01%     
==========================================
  Files         152      152              
  Lines        5531     5531              
==========================================
+ Hits         4946     4947       +1     
+ Misses        585      584       -1
Impacted Files Coverage Δ
starfish/core/intensity_table/intensity_table.py 97.14% <ø> (+0.71%) ⬆️
starfish/core/types/_constants.py 98.11% <0%> (-1.89%) ⬇️
...arfish/core/expression_matrix/expression_matrix.py 50% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30ec157...edd9c9c. Read the comment docs.

@shanaxel42 shanaxel42 requested a review from ttung June 18, 2019 22:41
@ttung
Copy link
Collaborator

ttung commented Jun 19, 2019

note that travis is not green, because the test environment does not have anndata installed.

@shanaxel42 shanaxel42 merged commit 89dc61e into master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExpressionMatrix methods
3 participants