Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn and return empty SpotAttributes when PixelDecoding finds 0 spots #1400

Merged
merged 4 commits into from
Jun 14, 2019

Conversation

shanaxel42
Copy link
Collaborator

fixes: #1275

Test: Run BaristaSeq with Clip(expand_dynamic_range=False)

@shanaxel42 shanaxel42 requested a review from ambrosejcarr June 10, 2019 23:12
@codecov-io
Copy link

codecov-io commented Jun 10, 2019

Codecov Report

Merging #1400 into master will decrease coverage by 1.27%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1400      +/-   ##
==========================================
- Coverage   90.69%   89.41%   -1.28%     
==========================================
  Files         223      152      -71     
  Lines        8520     5536    -2984     
==========================================
- Hits         7727     4950    -2777     
+ Misses        793      586     -207
Impacted Files Coverage Δ
.../spots/_detect_pixels/combine_adjacent_features.py 85.32% <50%> (-1.35%) ⬇️
starfish/core/image/_filter/element_wise_mult.py 88.57% <0%> (-1.43%) ⬇️
starfish/core/experiment/test/test_experiment.py
starfish/core/recipe/test/test_runnable.py
starfish/core/image/_filter/test/test_reduce.py
starfish/core/imagestack/test/test_export.py
...intensity_table/test/test_synthetic_intensities.py
...rfish/core/intensity_table/test/test_to_mermaid.py
starfish/core/test/factories.py
...tarfish/core/image/_filter/test/test_call_bases.py
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64159c8...0bbece0. Read the comment docs.

@shanaxel42 shanaxel42 merged commit 30ec157 into master Jun 14, 2019
@shanaxel42 shanaxel42 deleted the saxelrod-pixel-no-spots-error branch June 14, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PixelSpotDecoder throws an error when no spots are detected
3 participants