Codify the expectation that in-place experiment construction does not rely on TileFetcher data #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1389 +/- ##
=======================================
Coverage 89.45% 89.45%
=======================================
Files 152 152
Lines 5527 5527
=======================================
Hits 4944 4944
Misses 583 583Continue to review full report at Codecov.
|
shanaxel42
approved these changes
Jun 10, 2019
… rely on TileFetcher data When we construct an experiment in-place, the source data comes from the tiles already on disk. Therefore, whatever image data we provide the TileFetcher that we pass into `write_experiment_json` should be discarded. This verifies that the data from the tiles on the disk are what gets constituted into the experiment, and that the data returned by TileFetcher is ignored. Test plan: passed the test. Fixes #1388
ttung
pushed a commit
that referenced
this pull request
Jul 1, 2019
… to implement #1389 codifies the expectation that in-place tile construction does not rely on the data from `tile_data()`. This removes the requirement that in-place tile construction even needs to implement `tile_data()` by providing a default implementation. Note that this doesn't preclude someone from implementing `tile_data()` (example: the structured data formatter in #1421) for cases where the TileFetcher can be used inplace or non-inplace. Test plan: travis
ttung
pushed a commit
that referenced
this pull request
Jul 3, 2019
… to implement (#1429) #1389 codifies the expectation that in-place tile construction does not rely on the data from `tile_data()`. This removes the requirement that in-place tile construction even needs to implement `tile_data()` by providing a default implementation. Note that this doesn't preclude someone from implementing `tile_data()` (example: the structured data formatter in #1421) for cases where the TileFetcher can be used inplace or non-inplace. Test plan: travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we construct an experiment in-place, the source data comes from the tiles already on disk. Therefore, whatever image data we provide the TileFetcher that we pass into
write_experiment_jsonshould be discarded. This verifies that the data from the tiles on the disk are what gets constituted into the experiment, and that the data returned by TileFetcher is ignored.Test plan: passed the test.
Fixes #1388