Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smFISH notebook. #1383

Merged
merged 1 commit into from
May 31, 2019
Merged

Fix smFISH notebook. #1383

merged 1 commit into from
May 31, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented May 30, 2019

  1. iterate_image_type is now deprecated. Use get_images instead.
  2. Remove extra call to get_image(..). The output is not used anywhere.

Test plan: python notebooks/py/smFISH.py

@ttung ttung requested a review from ambrosejcarr May 30, 2019 08:42
@codecov-io
Copy link

codecov-io commented May 30, 2019

Codecov Report

Merging #1383 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1383   +/-   ##
======================================
  Coverage    89.4%   89.4%           
======================================
  Files         149     149           
  Lines        5416    5416           
======================================
  Hits         4842    4842           
  Misses        574     574

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f3a84...f20a6a5. Read the comment docs.

@ttung ttung force-pushed the tonytung-fix-smfish branch 2 times, most recently from 96ad899 to b195071 Compare May 31, 2019 06:00
1. `iterate_image_type` is now deprecated.  Use `get_images` instead.
2. Remove extra call to `get_image(..)`.  The output is not used anywhere.

Test plan: python notebooks/py/smFISH.py
@ttung ttung force-pushed the tonytung-fix-smfish branch from b195071 to f20a6a5 Compare May 31, 2019 06:05
@ttung
Copy link
Collaborator Author

ttung commented May 31, 2019

Gonna unbreak master. #yolo

@ttung ttung merged commit d3896a3 into master May 31, 2019
@ttung ttung deleted the tonytung-fix-smfish branch May 31, 2019 06:19
ttung pushed a commit that referenced this pull request May 31, 2019
ttung pushed a commit that referenced this pull request May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants