Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inplace TileFetcher options back to public builder API #1375

Merged
merged 1 commit into from
May 24, 2019
Merged

Add inplace TileFetcher options back to public builder API #1375

merged 1 commit into from
May 24, 2019

Conversation

njmei
Copy link
Collaborator

@njmei njmei commented May 24, 2019

This commit addresses an import error encountered
when trying to import inplace TileFetcher functionality.

Though if you want to keep the inplace stuff a secret
option for now, that's understandable too...

Example failing import:

from starfish.experiment.builder.inplace import (
    InplaceFetchedTile,
    enable_inplace_mode,
    inplace_tile_opener)

@codecov-io
Copy link

codecov-io commented May 24, 2019

Codecov Report

Merging #1375 into master will decrease coverage by 1.29%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1375     +/-   ##
========================================
- Coverage   90.49%   89.2%   -1.3%     
========================================
  Files         217     148     -69     
  Lines        8304    5374   -2930     
========================================
- Hits         7515    4794   -2721     
+ Misses        789     580    -209
Impacted Files Coverage Δ
starfish/experiment/builder.py 0% <0%> (ø) ⬆️
starfish/core/experiment/test/test_experiment.py
starfish/core/recipe/test/test_runnable.py
starfish/core/spacetx_format/test/test_validate.py
starfish/core/imagestack/test/test_export.py
...table/test/test_stack_intensity_table_reshaping.py
...rfish/core/intensity_table/test/test_to_mermaid.py
starfish/core/test/factories.py
...tarfish/core/image/_filter/test/test_call_bases.py
starfish/core/test/test_synthetic_spot_creation.py
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a4ec3c...2005a3a. Read the comment docs.

This commit addresses an import error encountered
when trying to import inplace TileFetcher functionality.

Example failing import that will be fixed by this commit:

from starfish.experiment.builder.inplace import (
    InplaceFetchedTile,
    enable_inplace_mode,
    inplace_tile_opener)
@njmei
Copy link
Collaborator Author

njmei commented May 24, 2019

@ttung: Rebased/squashed so that this is only 1 commit. Please merge if everything looks good and tests pass.

@ttung ttung merged commit 5bbd0c5 into spacetx:master May 24, 2019
@njmei njmei deleted the njmei-add-inplace-tiles-back-to-api branch May 24, 2019 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants