Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TileFetcher formats complete 496 fov MERFISH dataset #1341

Merged
merged 2 commits into from
May 29, 2019

Conversation

ambrosejcarr
Copy link
Member

  • Update tilefetcher to format complete dataset instead of 1 fov

Testing strategy:

import starfish.data
exp = starfish.Experiment.from_json(https://d2nhj9g34unfro.cloudfront.net/browse/formatted/MERFISH/20190511/
exp  # do things, verify 496 fovs

@ambrosejcarr ambrosejcarr self-assigned this May 11, 2019
@ambrosejcarr ambrosejcarr requested a review from shanaxel42 May 11, 2019 14:00
@codecov-io
Copy link

codecov-io commented May 11, 2019

Codecov Report

Merging #1341 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
+ Coverage   89.02%   89.04%   +0.01%     
==========================================
  Files         147      147              
  Lines        5295     5295              
==========================================
+ Hits         4714     4715       +1     
+ Misses        581      580       -1
Impacted Files Coverage Δ
starfish/core/types/_constants.py 100% <0%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f977425...7da3dab. Read the comment docs.

@ambrosejcarr ambrosejcarr merged commit bfc5f8d into master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants