Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding windows install instructions #1227

Merged
merged 2 commits into from
Apr 22, 2019
Merged

Adding windows install instructions #1227

merged 2 commits into from
Apr 22, 2019

Conversation

shanaxel42
Copy link
Collaborator

I was a little more specific about how to install a pip and a virtualenv since I ran into lots of issues with accidentally overriding apt-get files.

@codecov-io
Copy link

codecov-io commented Apr 19, 2019

Codecov Report

Merging #1227 into master will decrease coverage by 20.89%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1227      +/-   ##
==========================================
- Coverage   88.38%   67.48%   -20.9%     
==========================================
  Files         132      133       +1     
  Lines        4897     5262     +365     
==========================================
- Hits         4328     3551     -777     
- Misses        569     1711    +1142
Impacted Files Coverage Δ
starfish/experiment/builder/inplace.py 0% <0%> (-87.88%) ⬇️
starfish/test/full_pipelines/api/test_dartfish.py 20% <0%> (-80%) ⬇️
starfish/test/full_pipelines/api/test_iss_api.py 23.52% <0%> (-76.48%) ⬇️
starfish/test/full_pipelines/api/test_merfish.py 24.39% <0%> (-75.61%) ⬇️
starfish/experiment/builder/__init__.py 30.35% <0%> (-69.65%) ⬇️
starfish/intensity_table/overlap.py 31.37% <0%> (-64.71%) ⬇️
.../spots/_detect_spots/local_search_blob_detector.py 30.38% <0%> (-63.69%) ⬇️
starfish/spacetx_format/test_fuzz.py 37.5% <0%> (-62.5%) ⬇️
starfish/spacetx_format/util.py 37.5% <0%> (-58.34%) ⬇️
starfish/util/click/__init__.py 40.74% <0%> (-55.56%) ⬇️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc96759...a37fb0a. Read the comment docs.

Copy link
Member

@ambrosejcarr ambrosejcarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test this myself, but this looks solid to me.

Copy link
Collaborator

@ttung ttung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks

@shanaxel42 shanaxel42 merged commit 37ce50b into master Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants