Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize names for PipelineComponents #1218

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Normalize names for PipelineComponents #1218

merged 1 commit into from
Apr 19, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Apr 18, 2019

The CLI name for PipelineComponent should match the API name.

Test plan: travis

@ttung ttung force-pushed the tonytung-normalize branch 2 times, most recently from 9d468c2 to eb4b57e Compare April 18, 2019 19:21
@codecov-io
Copy link

codecov-io commented Apr 18, 2019

Codecov Report

Merging #1218 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1218      +/-   ##
==========================================
- Coverage    88.5%   88.42%   -0.08%     
==========================================
  Files         133      133              
  Lines        4974     4923      -51     
==========================================
- Hits         4402     4353      -49     
+ Misses        572      570       -2
Impacted Files Coverage Δ
.../spots/_detect_pixels/combine_adjacent_features.py 90.42% <ø> (ø)
...rfish/test/full_pipelines/cli/test_dartfish_cli.py 100% <ø> (ø) ⬆️
starfish/spots/_detect_spots/detect.py 98.3% <ø> (ø)
...h/test/full_pipelines/cli/test_allen_smFISH_cli.py 75% <ø> (ø) ⬆️
starfish/pipeline/algorithmbase.py 97.72% <ø> (ø) ⬆️
starfish/test/full_pipelines/cli/test_iss.py 100% <ø> (ø) ⬆️
...arfish/test/full_pipelines/cli/test_merfish_cli.py 75% <ø> (ø) ⬆️
starfish/spots/_detect_pixels/_base.py 84.61% <100%> (ø)
.../spots/_detect_spots/local_search_blob_detector.py 94.06% <100%> (ø)
starfish/pipeline/pipelinecomponent.py 95.65% <100%> (+2.79%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6f7fb3...8616308. Read the comment docs.

@ttung ttung mentioned this pull request Apr 18, 2019
@ttung ttung force-pushed the tonytung-normalize branch from eb4b57e to 2f16010 Compare April 18, 2019 19:58
Copy link
Member

@ambrosejcarr ambrosejcarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, but suggest one more change.

starfish/spots/_target_assignment/_base.py Outdated Show resolved Hide resolved
@ttung ttung force-pushed the tonytung-normalize branch 3 times, most recently from 5f56b55 to 057649b Compare April 19, 2019 06:47
The CLI name for PipelineComponent should match the API name.

Test plan: travis
@ttung ttung force-pushed the tonytung-normalize branch from 057649b to 8616308 Compare April 19, 2019 16:10
@ttung ttung merged commit 051f77c into master Apr 19, 2019
@ttung ttung deleted the tonytung-normalize branch April 19, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants