vectorize labeling spot lookups #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1215 +/- ##
==========================================
+ Coverage 88.52% 88.52% +<.01%
==========================================
Files 133 133
Lines 4976 4968 -8
==========================================
- Hits 4405 4398 -7
+ Misses 571 570 -1
Continue to review full report at Codecov.
|
* replace xarray groupby with pandas groupby command to expedite processing time of combine_adjacent_features.
ambrosejcarr
force-pushed
the
ajc-vectorize-label
branch
from
5bb43b1 to
cdc0ae3
Compare
ttung
reviewed
May 1, 2019
| & (intensities.y <= y_max) | ||
| & (intensities.x >= x_min) | ||
| & (intensities.x <= x_max), | ||
| drop=True |
There was a problem hiding this comment.
would it make sense to add: intensities.cell_id != nan?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to knock some seconds off of starfish. Here's part 2!
before:
after: