Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing Clip.SCALE_BY_IMAGE #1193

Merged
merged 2 commits into from
Apr 17, 2019
Merged

fixing Clip.SCALE_BY_IMAGE #1193

merged 2 commits into from
Apr 17, 2019

Conversation

shanaxel42
Copy link
Collaborator

overwrite the Imagestacks numpy array with the result of preserve_float_range() instead of the xarray

fixes #1184

@shanaxel42 shanaxel42 requested a review from ambrosejcarr April 16, 2019 17:33
@codecov-io
Copy link

codecov-io commented Apr 16, 2019

Codecov Report

Merging #1193 into master will decrease coverage by 0.56%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1193      +/-   ##
==========================================
- Coverage   88.48%   87.91%   -0.57%     
==========================================
  Files         129      135       +6     
  Lines        4931     5518     +587     
==========================================
+ Hits         4363     4851     +488     
- Misses        568      667      +99
Impacted Files Coverage Δ
starfish/imagestack/imagestack.py 94.62% <100%> (+0.63%) ⬆️
...h/spots/_detector/trackpy_local_max_peak_finder.py 90.14% <0%> (-1.53%) ⬇️
starfish/compat.py 10.07% <0%> (-0.77%) ⬇️
starfish/image/_filter/linear_unmixing.py 96.07% <0%> (-0.7%) ⬇️
starfish/test/full_pipelines/api/test_iss_api.py 100% <0%> (ø) ⬆️
starfish/imagestack/test/factories/with_coords.py 100% <0%> (ø)
starfish/imagestack/test/factories/unique_tiles.py 97.67% <0%> (ø)
...rfish/imagestack/test/factories/synthetic_stack.py 100% <0%> (ø)
starfish/intensity_table/overlap.py 96.07% <0%> (ø)
starfish/imagestack/test/factories/__init__.py 100% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f186036...cf1e826. Read the comment docs.

@shanaxel42 shanaxel42 merged commit 664aa70 into master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clip.SCALE_BY_IMAGE causes the xarray to be replaced by a numpy array
3 participants