-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe and recipe execution #1192
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1192 +/- ##
==========================================
+ Coverage 88.42% 88.66% +0.23%
==========================================
Files 136 137 +1
Lines 5071 5168 +97
==========================================
+ Hits 4484 4582 +98
+ Misses 587 586 -1
Continue to review full report at Codecov.
|
starfish/recipe/recipe.py
Outdated
ordered_sequence = OrderedSequence() | ||
file_outputs: MutableMapping[int, Runnable] = {} | ||
recipe_scope = { | ||
"Axes": Axes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this info?
62a9474
to
aeeec4f
Compare
e5c2ef4
to
b821904
Compare
967c275
to
af72897
Compare
af72897
to
8741e29
Compare
c97d827
to
78ffea6
Compare
30131d5
to
65c9fcb
Compare
2821750
to
c472b10
Compare
ae2e012
to
e7afa06
Compare
e7afa06
to
e8d86b0
Compare
a2452c4
to
744112b
Compare
e8d86b0
to
8407918
Compare
8407918
to
ec49c0e
Compare
2f827bf
to
62b1ebb
Compare
f1808b6
to
bcd4ed7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Where are the docs? ;-)
cb07126
to
920b571
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Did I miss documentation of the deviations from python-style code (e.g. the @
symbol)?
05caa43
to
c7ef79c
Compare
2f42b0f
to
4cfc692
Compare
you did. that is a CLI-ism. Not a recipe thing. |
e8bb437
to
1038482
Compare
ec53c50
to
61dd567
Compare
Builds on top of #1097 to construct and run recipes with one or more runnables. A recipe wires together one or more runnables. Inputs to recipes are available to the recipe itself as the magic variable name "file_inputs". A runnable is invoked by the magic function "compute". Anything written to the magic variable "file_outputs" is matched and written out to a set of output paths. Fixes #311
Builds on top of #1163 to construct and run recipes with one or more runnables.
A recipe wires together one or more runnables. Inputs to recipes are available to the recipe itself as the magic variable name "file_inputs". A runnable is invoked by the magic function "compute". Anything written to the magic variable "file_outputs" is matched and written out to a set of output paths.
This is a continuation of #1117
Fixes #311