Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BaristaSeq text, fix LinearUnmixing #1188

Merged
merged 7 commits into from
Apr 16, 2019

Conversation

ambrosejcarr
Copy link
Member

This PR addresses scientific issues in BaristaSeq:

  • LinearUnmixing was doing the wrong thing (summing over the wrong axis, which led to incorrect unmixing)
  • Updates text in BaristaSeq.py
  • BaristaSeq is small enough that it can be rendered by readthedocs as it stands, so testing it there and removing the out-of-date .py and .ipynb

If we decide to keep checking in notebooks, this can be reversed by downloading the .ipynb file and checking it back in.

@ambrosejcarr ambrosejcarr requested a review from dganguli April 15, 2019 18:59
@codecov-io
Copy link

codecov-io commented Apr 15, 2019

Codecov Report

Merging #1188 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1188      +/-   ##
==========================================
+ Coverage   88.15%   88.16%   +<.01%     
==========================================
  Files         129      129              
  Lines        4949     4950       +1     
==========================================
+ Hits         4363     4364       +1     
  Misses        586      586
Impacted Files Coverage Δ
starfish/image/_filter/linear_unmixing.py 96.87% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c003e16...8b471c5. Read the comment docs.

@dganguli
Copy link
Collaborator

should un-delete the notebook for spacejam. pretty please?

@ambrosejcarr ambrosejcarr force-pushed the ajc-baristaseq-notebook branch from efaedb0 to f58c7a0 Compare April 16, 2019 23:18
@ambrosejcarr ambrosejcarr force-pushed the ajc-baristaseq-notebook branch from f58c7a0 to 8b471c5 Compare April 16, 2019 23:23
@ambrosejcarr ambrosejcarr merged commit 81b39b7 into master Apr 16, 2019
@ambrosejcarr ambrosejcarr deleted the ajc-baristaseq-notebook branch April 16, 2019 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants