Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a pip config file. #1085

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Use a pip config file. #1085

merged 1 commit into from
Mar 26, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Mar 15, 2019

This replaces #1080, and depends on #1084

Test plan: make docker

@ttung ttung requested a review from joshmoore March 15, 2019 17:39
@ttung ttung mentioned this pull request Mar 15, 2019
Closed
@codecov-io
Copy link

codecov-io commented Mar 15, 2019 •
edited
Loading

Codecov Report

Merging #1085 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1085   +/-   ##
=======================================
  Coverage   90.81%   90.81%           
=======================================
  Files         164      164           
  Lines        6151     6151           
=======================================
  Hits         5586     5586           
  Misses        565      565

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce318c1...1305517. Read the comment docs.

@joshmoore
Copy link
Member

This needs the pip-config, no?

@ttung ttung changed the base branch from tonytung-docker to master March 15, 2019 18:34
@ttung ttung force-pushed the tonytung-pip-config branch from 2f262b4 to 1f919d2 Compare March 15, 2019 18:35
Use a pip config file.
1305517 
Test plan: `make docker`
@ttung ttung force-pushed the tonytung-pip-config branch from 1f919d2 to 1305517 Compare March 15, 2019 18:35
@ttung
Copy link
Collaborator Author

ttung commented Mar 15, 2019

derp, added pip-config.

joshmoore
joshmoore approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just building locally, but looks as I'd expect. 👍

ttung pushed a commit that referenced this pull request Mar 15, 2019
Use a pip config file. (#1085)
0394120 
This replaces #1080, and depends on #1084

Test plan: `make docker`
@joshmoore
Copy link
Member

joshmoore commented Mar 15, 2019 •
edited
Loading 

Successfully built ab4c3b5d1128
Successfully tagged spacetx/starfish:latest
docker run -ti --rm spacetx/starfish build --fov-count 1 --primary-image-dimensions '{"z": 1}' /tmp/

         _              __ _     _
        | |            / _(_)   | |
     ___| |_ __ _ _ __| |_ _ ___| |__
    / __| __/ _` | '__|  _| / __| '_  `
    \__ \ || (_| | |  | | | \__ \ | | |
    |___/\__\__,_|_|  |_| |_|___/_| |_|

@ttung ttung merged commit 50d00d9 into master Mar 26, 2019
@ttung ttung deleted the tonytung-pip-config branch March 26, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmoore joshmoore joshmoore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttung @codecov-io @joshmoore