Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to verify that ImageStack with labeled axes -> IntensityTable works correctly #1168

Closed
ttung opened this issue Apr 11, 2019 · 1 comment · Fixed by #1181
Closed

Add test to verify that ImageStack with labeled axes -> IntensityTable works correctly #1168

ttung opened this issue Apr 11, 2019 · 1 comment · Fixed by #1181
Assignees
@ttung
Labels
high priority
Milestone
0.1.0

Comments

@ttung
Copy link
Collaborator

ttung commented Apr 11, 2019

No description provided.

@ttung ttung added this to the 0.1.0 milestone Apr 11, 2019
@ttung ttung self-assigned this Apr 11, 2019
@ttung
Copy link
Collaborator Author

ttung commented Apr 12, 2019

Confirmed, this does not work.

@ttung ttung mentioned this issue Apr 12, 2019
Merged
@ttung ttung mentioned this issue Apr 14, 2019
Merged
ttung pushed a commit that referenced this issue Apr 18, 2019
Allow for intensity tables with labeled axes
bd6e533 
Currently, we use the offset of r/c/z to label the axes on the intensity table.  We should instead be using the axes labels from the ImageStack.  This PR makes that change in three key areas:

1. `IntensityTable.empty_intensity_table` now accepts the labels for the axes.
2. `IntensityTable.from_spot_data` now accepts the labels for the axes and verifies that the number of labels matches the intensity data.
3. `IntensityTable.from_image_stack` reads the labels for the zplane axes and assigns them correctly.

Test plan: Add a test that instantiates a labeled ImageStack and derives an IntensityTable from it.  Also ran `make test && make -j run-notebooks`.

Depends on #1178
Fixes #1168
ttung added a commit that referenced this issue Apr 18, 2019
@ttung
Allow for intensity tables with labeled axes (#1181)
64f3e5a 
Currently, we use the offset of r/c/z to label the axes on the intensity table.  We should instead be using the axes labels from the ImageStack.  This PR makes that change in three key areas:

1. `IntensityTable.empty_intensity_table` now accepts the labels for the axes.
2. `IntensityTable.from_spot_data` now accepts the labels for the axes and verifies that the number of labels matches the intensity data.
3. `IntensityTable.from_image_stack` reads the labels for the zplane axes and assigns them correctly.

Test plan: Add a test that instantiates a labeled ImageStack and derives an IntensityTable from it.  Also ran `make test && make -j run-notebooks`.

Depends on #1178
Fixes #1168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttung ttung

Labels
high priority
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Allow for intensity tables with labeled axes spacetx/starfish
1 participant
@ttung