Eliminate string construction of file:// urls. #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 75.57% 78.31% +2.73%
==========================================
Files 29 29
Lines 913 913
==========================================
+ Hits 690 715 +25
+ Misses 223 198 -25
Continue to review full report at Codecov.
|
ttung
force-pushed
the
tonytung-pathlib
branch
3 times, most recently
from
54be498 to
82baf7c
Compare
shanaxel42
approved these changes
Aug 30, 2019
Use Pathlib's `as_uri()` method, which is cross-platform. Test plan: `make test` Part of spacetx/starfish#1296
ttung
force-pushed
the
tonytung-pathlib
branch
from
82baf7c to
42f02e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Pathlib's
as_uri()method, which is cross-platform.Test plan:
make testPart of spacetx/starfish#1296