Simplify HTTP connection code #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttung
force-pushed
the
tonytung-simplify-connection
branch
2 times, most recently
from
41437f0 to
b0254bc
Compare
We removed python 2.x support in #102, so this code should and can be simplified. Test plan: `make -j test`
ttung
force-pushed
the
tonytung-simplify-connection
branch
from
b0254bc to
855ea4c
Compare
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
=======================================
Coverage 75.57% 75.57%
=======================================
Files 29 29
Lines 913 913
=======================================
Hits 690 690
Misses 223 223Continue to review full report at Codecov.
|
shanaxel42
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed python 2.x support in #102, so this code should and can be simplified.
Test plan:
make -j test