Fix Windows path resolution #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When extracting the path component from urllib.parse.urlparse, the path always starts with '/'. When tokenizing the url into its components, it becomes '/', 'c:', 'windows', 'system32'. Unfortunately, when combined into a WindowsPath, it becomes 'c:windows/system32', which honestly makes no sense to me. The approach here is to strip the prefix '/', and when we do that, WindowsPath can parse the posix path correctly. Test plan: Ran this on a Windows VM.
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 75.49% 75.41% -0.09%
==========================================
Files 29 29
Lines 906 907 +1
==========================================
Hits 684 684
- Misses 222 223 +1
Continue to review full report at Codecov.
|
shanaxel42
approved these changes
Aug 6, 2019
ttung
pushed a commit
that referenced
this pull request
Sep 3, 2019
This is the same issue as #112, so I added a general method to do this conversion.
ttung
pushed a commit
that referenced
this pull request
Sep 5, 2019
This is the same issue as #112, so I added a general method to do this conversion.
ttung
pushed a commit
that referenced
this pull request
Sep 5, 2019
This is the same issue as #112, so I added a general method to do this conversion.
ttung
pushed a commit
that referenced
this pull request
Sep 5, 2019
This is the same issue as #112, so I added a general method to do this conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When extracting the path component from urllib.parse.urlparse, the path always starts with '/'. When tokenizing the url into its components, it becomes '/', 'c:', 'windows', 'system32'. Unfortunately, when combined into a WindowsPath, it becomes 'c:windows/system32', which honestly makes no sense to me.
The approach here is to strip the prefix '/', and when we do that, WindowsPath can parse the posix path correctly.
Thanks to @dany-fu for reporting this.
Test plan: loaded up a very empty experiment.json on a Windows VM.