Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inttag: remove sherpagehrels ERR outputs #162

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sean-lockwood
Copy link
Member

Removed the inttag 2D error extensions calculated using the 'sherpagehrels' upper confidence interval. With a null data array in the ERR extension, CalSTIS will now default to using Gaussian noise statistics.

Based on the analysis by Joshua Lothringer (@jlothringer).

Updated inttag to v1.1.

…hrels' upper confidence interval. With a null data array in the ERR extension, CalSTIS will now default to using Gaussian noise statistics.

Based on the analysis by Joshua Lothringer (@jlothringer).
@sean-lockwood sean-lockwood self-assigned this Mar 27, 2024
@sean-lockwood sean-lockwood requested a review from a team as a code owner March 27, 2024 21:48
Copy link

@jlothringer jlothringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fetched the new branch in a new environment, re-reduced some E230M TIME-TAG data with inttag+calstis, and got the desired, expected result for the errors in the subexposures. So this looks good to me.

W121b_INTTAG_flux_errors_FIX

@sean-lockwood sean-lockwood requested a review from stscirij March 28, 2024 14:13
@sean-lockwood
Copy link
Member Author

Just confirmed no tests touch on the ERR extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants