Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move build configuration into pyproject.toml #145

Merged
merged 7 commits into from
Feb 25, 2023

Conversation

zacharyburnett
Copy link
Collaborator

setuptools now supports the [project] table, which is defined by PEP621.

Additionally, setuptools now supports its own entry in pyproject.toml called [tool.setuptools] (pypa/setuptools#1688, https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration); however, it comes with the following disclaimer:

Support for declaring configurations not standardized by PEP 621 (i.e. the [tool.setuptools] table), is still in beta stage and might change in future releases.

It is likely that this functionality with setuptools will leave beta stage upon the release of Python 3.11, with its native implementation of tomli

Given this, we can attempt to consolidate the build configuration into a single pyproject.toml file that can possibly be read by other build systems in the future.

@zacharyburnett zacharyburnett force-pushed the pep621 branch 2 times, most recently from 44911c1 to 8aa96bc Compare September 20, 2022 14:04
@zacharyburnett zacharyburnett force-pushed the pep621 branch 2 times, most recently from f33ff6c to 37de4d5 Compare January 20, 2023 20:35
@zacharyburnett zacharyburnett marked this pull request as ready for review January 20, 2023 20:38
@zacharyburnett zacharyburnett self-assigned this Feb 15, 2023
@zacharyburnett zacharyburnett requested a review from nden February 15, 2023 13:40
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Feb 23, 2023

removing reliance on relic with this PR would also solve this issue: spacetelescope/stenv#78

@zacharyburnett zacharyburnett merged commit 5c2d10e into spacetelescope:master Feb 25, 2023
@zacharyburnett zacharyburnett deleted the pep621 branch February 25, 2023 16:34
@sean-lockwood
Copy link
Member

@zacharyburnett -
The RTD site was rebuilt around the time this PR was merged. It looks like the docs built without autodoc, as most of the function descriptions are now blank.

E.g.:
https://stistools.readthedocs.io/en/latest/inttag.html

image

@zacharyburnett
Copy link
Collaborator Author

The RTD site was rebuilt around the time this PR was merged. It looks like the docs built without autodoc, as most of the function descriptions are now blank.

That is strange; they populate on HTML built locally on my machine. I will look into this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants