Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated get_fileext() method #400

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Remove deprecated get_fileext() method #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4c9edb
Remove deprecated get_fileext() method
emolter Feb 12, 2025
3cd8546
add changelog entry
emolter Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/400.removal.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove deprecated DataModel.get_fileext() method
8 changes: 0 additions & 8 deletions src/stdatamodels/model_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,14 +1007,6 @@ def convert_val(val):
def schema(self):
return self._schema

def get_fileext(self):
warnings.warn(
"get_fileext always returns 'fits' and will be removed in an upcoming release",
DeprecationWarning,
stacklevel=2,
)
return "fits"

@property
def history(self):
"""
Expand Down
6 changes: 0 additions & 6 deletions tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,9 +341,3 @@ def find_gen_by_id(object_id):
# many models which would indicate they are difficult to garbage
# collect.
assert len(mids) < 2


def test_get_fileext_deprecation():
m = DataModel()
with pytest.warns(DeprecationWarning):
assert m.get_fileext() == "fits"