-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move build configuration into pyproject.toml
#95
move build configuration into pyproject.toml
#95
Conversation
Codecov ReportBase: 70.45% // Head: 70.45% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
=======================================
Coverage 70.45% 70.45%
=======================================
Files 15 15
Lines 2623 2623
=======================================
Hits 1848 1848
Misses 775 775 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
0333f5e
to
7f3fd3d
Compare
7f3fd3d
to
77abb2f
Compare
e5f7177
to
5d989b4
Compare
ee9aad0
to
9424843
Compare
2755179
to
8969eae
Compare
205e030
to
1da1e91
Compare
1da1e91
to
e940da5
Compare
Now that Python 3.11 includes |
If [tool.setuptools]
zip-safe = true
[tool.setuptools.packages.find]
where = ['src'] The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
setuptools
now supports the[project]
table, which is defined by PEP621.Additionally,
setuptools
now supports its own entry inpyproject.toml
called[tool.setuptools]
(pypa/setuptools#1688, https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration); however, it comes with the following disclaimer:Given this, we can attempt to consolidate the build configuration into a single
pyproject.toml
file that can possibly be read by other build systems in the future.