Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test artifacts to B11 tests. #72

Merged
merged 6 commits into from
Aug 31, 2023

Conversation

schlafly
Copy link
Collaborator

This PR adds some asdf binary files with the various images & test statistics computed during the B11 tests.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9e46dcb) 93.18% compared to head (11f0f79) 93.18%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   93.18%   93.18%           
=======================================
  Files          16       16           
  Lines        1424     1424           
=======================================
  Hits         1327     1327           
  Misses         97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly schlafly marked this pull request as ready for review August 25, 2023 18:10
@schlafly schlafly requested a review from a team as a code owner August 25, 2023 18:10
@schlafly schlafly requested a review from PaulHuwe August 25, 2023 18:10
@schlafly
Copy link
Collaborator Author

@PaulHuwe , care to review briefly? This adds some ~artifacts to the regression tests for B11, basically writing out the things we already compute so that they're available for inspection by others.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schlafly schlafly merged commit 02eb229 into spacetelescope:main Aug 31, 2023
@schlafly schlafly deleted the test-artifacts branch August 31, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants