Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not error out with negative scales #185

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

stscieisenhamer
Copy link
Collaborator

The code to not error on negative scales, and the update of the dependencies, did not make it into a previous PR. This resolves both those issues.

@stscieisenhamer stscieisenhamer requested a review from a team as a code owner December 4, 2024 18:18
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.31%. Comparing base (244858c) to head (0a63df5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   90.02%   90.31%   +0.29%     
==========================================
  Files          17       17              
  Lines        2165     2168       +3     
==========================================
+ Hits         1949     1958       +9     
+ Misses        216      210       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stscieisenhamer
Copy link
Collaborator Author

regression test

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. I presume this will fix the build errors on the other open PRs.

@schlafly schlafly merged commit 1b967fd into spacetelescope:main Dec 5, 2024
21 of 22 checks passed
@stscieisenhamer
Copy link
Collaborator Author

A closer examination of the skipped job indicates that the CI is using a MacOS configuration, macOS-12, that is deprecated. Not being versed in the lore of CI configuration, this issue has been brought to the attention of the build engineers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants